-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocols constructor argument to WebTransport + protocol read arg #598
Conversation
Meeting:
|
index.bs
Outdated
[Section 4.1](https://datatracker.ietf.org/doc/html/draft-ietf-webtrans-overview-06#section-4.1-2.2.1), | ||
with using |origin|, [=ASCII serialization of an origin|serialized=] and [=isomorphic encoded=], | ||
as the [:Origin:] header of the request. | ||
When establishing a session, the client MUST NOT provide any [=credentials=]. | ||
The resulting underlying transport stream is referred to as the session's <dfn>CONNECT stream</dfn>. | ||
Additionally, if the [=underlying connection=] is using HTTP/3 and the |protocols| array is non-empty, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that you mentioned only specifying this for HTTP/3 as it's only defined in that IETF doc, but I'm not sure if making this HTTP/3 specific is what we want. We should probably file an issue to get it added to the HTTP/2 or overview doc as well, and keep the language here as protocol-agnostic as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this should be the goal. @nidhijaju or @vasilvv can you open this issue? But in the meantime, can we iterate here by merging what we have, and come back and fix this when it's available in the overview doc?
Co-authored-by: Nidhi Jaju <[email protected]>
Meeting:
|
Meeting:
|
Could we call this "applicationProtocol"? This avoids overloading the multiple references to internet protocols (UDP, QUIC, WebTransport) and instead refers to the protocol we wish to describe, which is defined completely by the application using the WebTransport connection. |
Meeting:
|
IETF preferred "protocol" by overwhelming margin in a poll (19 protocol, 3 subprotocol, 9 applicationLevelProtocol) |
Note ietf-wg-webtrans/draft-ietf-webtrans-overview#15 (comment), calling for harmonization around the use of "protocol". |
The API is now "protocol" throughout, except prose still uses "subprotocol" to disambiguate it from its own § 3. Protocol concepts (HTTP3 does a similar thing). |
s/subprotocol/protocol/ for variable names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/subprotocol/protocol based on last meeting
SHA: 11009de Reason: push, by nidhijaju Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes #536. Right now this seems only defined for HTTP/3, so that's what I went with. Is this what we want?
Preview | Diff