-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pointer event defaults #666
base: main
Are you sure you want to change the base?
Conversation
@jrandolf is it in the spec that the properties can be inferred? (could you please add a link) |
1c70c3e
to
fbf070f
Compare
This is implementation-defined. See https://www.w3.org/TR/webdriver2/#dfn-dispatch-a-pointerdown-action |
fbf070f
to
bc88960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (as the classic spec does not require actual default values). @juliandescottes @jgraham PTAL
The defaults match the defaults if you construct an event in the DOM API, per: https://www.w3.org/TR/pointerevents/#pointer-events-and-interfaces. I think that's what's intended by classic, and saying "this is just implementation defined" is not OK (authors should be able to depend on event properties being consistent between browsers for a given input). |
The defaults don't really make sense for a lot of events. For example, for pointer, the default pressure is always 0.5 (try it on any browser) |
That seems like a reason to update those specs, rather than a reason to throw our hands up and say "implementation defined". |
As an alternative, we can try to specify the defaults within WebDriver in detail. WDYT? |
We enforce default pointer properties although the WebDriver spec does not specify any.
Preview | Diff