Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "baseline" test vectors (no optional features) #183

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Jul 17, 2024

This PR is in response to issue #181. It updates the "baseline" BBS test vectors but does not update the optional feature test vectors. This update brings the test vectors in line with version 06 of the IETF BBS Signature Scheme draft. Optional feature test vectors will be updated in a separate PR.

These updates result only in cryptographic value changes in the separate text vector files which are imported into the specification via the ReSpec data-include mechanism. No API, procedure, textual, or formatting changes are included. Test vectors are non-normative.


Preview | Diff

Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM don't have anyway of verifying these though so we might want to wait on another implementation that can verify these work.

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to verify these via implementation in the near future.

…aft 06 updates. Only cryptographic value changes. No API/procedure/textual changes.
@msporny msporny force-pushed the test-vector-update branch from 02f2012 to b747f62 Compare August 16, 2024 15:26
@Wind4Greg Wind4Greg merged commit cacfa45 into w3c:main Aug 19, 2024
2 checks passed
@Wind4Greg
Copy link
Collaborator Author

Informative update only, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants