Specify wheel event groups #344

dlrobertson · 2023-03-16T01:46:03Z

Specify the behavior of wheel event groups.

Closes #338

The following tasks have been completed:

Confirmed there are no ReSpec/BikeShed errors or warnings.
Modified Web platform tests: Add test for wheel event groups web-platform-tests/wpt#37445

Implementation commitment:

WebKit: Passes tests in Add test for wheel event groups web-platform-tests/wpt#37445
Chromium: Passes tests in Add test for wheel event groups web-platform-tests/wpt#37445
Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=1168182)

dlrobertson

Just a first pass at describing wheel event groups. Critiques would be greatly appreciated!

dlrobertson · 2023-03-16T01:51:08Z

sections/event-types.txt

+			occur over the child element. In the case that {{Event/preventDefault()}}
+			is called in a wheel event handler for the child element, targetting
+			the child element could result in unexpected behavior for the user.
+			</p>


Not sure if the example text is helpful as is, but I thought some sort of example might clarify things.

I think having examples can be really useful.

I'm not sure what the takeaway is for this example, though. It ends with "could result in unexpected behavior", which makes it sound like a cautionary tale. Is this trying to explain why it is spec'ed this way, or is there something that the user needs to do to avoid the unexpected behavior?

I think my goal was "to explain why it is spec'ed this way". Is something like that typical in a spec or just contained to the spec issue and PR? This is also something that is easier to see with an actual example with a scrollable frame with a subframe that preventDefault's wheel events

IMO the last sentence is not necessary and might confuse more than clarify.

garykac · 2023-05-09T20:48:07Z

sections/event-types.txt

@@ -2180,11 +2180,12 @@ myDiv.addEventListener("auxclick", function(e) {
 			+| Sync / Async     | Async                                                                                |
 			+| Bubbles          | Yes                                                                                  |
 			+| Trusted Targets  | <code>Element</code>                                                                 |
-			+| Cancelable       | <a href="#cancelability-of-wheel-events">Varies</a>                                                  |
+			+| Cancelable       | <a href="#cancelability-of-wheel-events">Varies</a>                                  |
 			+| Composed         | Yes                                                                                  |


I assume that this change was not intentional.

Thanks, removed the change.

garykac · 2023-05-09T21:00:38Z

sections/event-types.txt

+			occur over the child element. In the case that {{Event/preventDefault()}}
+			is called in a wheel event handler for the child element, targetting
+			the child element could result in unexpected behavior for the user.
+			</p>


I think having examples can be really useful.

I'm not sure what the takeaway is for this example, though. It ends with "could result in unexpected behavior", which makes it sound like a cautionary tale. Is this trying to explain why it is spec'ed this way, or is there something that the user needs to do to avoid the unexpected behavior?

garykac · 2023-05-09T21:00:57Z

sections/glossary.txt

@@ -381,6 +381,12 @@ the definitions for more information.
 	the [[#conf-interactive-ua]] and [[#conf-author-tools]] for details on the
 	requirements for a <em>conforming</em> user agent.

+: <dfn>wheel event group</dfn>


We're moving away from having entries in glossary since they are not normative and mostly duplicate definitions that are properly defined elsewhere.

I think this should just be included up with the rest of the text.

dlrobertson

Thanks for the feedback!

dlrobertson · 2023-05-10T13:44:01Z

sections/event-types.txt

+			occur over the child element. In the case that {{Event/preventDefault()}}
+			is called in a wheel event handler for the child element, targetting
+			the child element could result in unexpected behavior for the user.
+			</p>


I think my goal was "to explain why it is spec'ed this way". Is something like that typical in a spec or just contained to the spec issue and PR? This is also something that is easier to see with an actual example with a scrollable frame with a subframe that preventDefault's wheel events

zcorpan · 2023-05-31T09:29:12Z

sections/event-types.txt

@@ -2023,6 +2023,21 @@ myDiv.addEventListener("auxclick", function(e) {
 	deltaY value respectively).
 	</p>

+	A <a>user agent</a> SHOULD create a <a>wheel event group</a> when the first wheel event


I would make this "MUST" so that it's well-defined what the target is for wheel events. The UA-defined timeout allows UAs to not implement the grouping already.

dlrobertson

Removed the last sentence of the example and changed setting the target to ensure it is well defined.

dlrobertson · 2023-06-02T13:03:26Z

sections/event-types.txt

@@ -2180,11 +2180,12 @@ myDiv.addEventListener("auxclick", function(e) {
 			+| Sync / Async     | Async                                                                                |
 			+| Bubbles          | Yes                                                                                  |
 			+| Trusted Targets  | <code>Element</code>                                                                 |
-			+| Cancelable       | <a href="#cancelability-of-wheel-events">Varies</a>                                                  |
+			+| Cancelable       | <a href="#cancelability-of-wheel-events">Varies</a>                                  |
 			+| Composed         | Yes                                                                                  |


Thanks, removed the change.

dlrobertson · 2023-06-27T13:14:36Z

See web-platform-tests/wpt#37445 (comment), in particular:

I think I'd still prefer to call this thing something else than "event group". It is more like a wheel transaction or some such.

I'll update the text here to use "wheel transaction" instead of "wheel event group"

CC @smaug----

zcorpan

LGTM but needs a rebase.

Specify the behavior of wheel event groups.

dlrobertson · 2023-12-04T15:34:57Z

@zcorpan @garykac rebased

SHA: ee7998e Reason: push, by garykac Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dlrobertson · 2023-12-04T21:25:38Z

\o/ Thanks @zcorpan and @garykac!

dlrobertson commented Mar 16, 2023

View reviewed changes

dlrobertson force-pushed the wheel-event-groups branch from 5c81ac6 to ad9d8d3 Compare March 17, 2023 03:29

dlrobertson mentioned this pull request Mar 29, 2023

Wheel event groups are not defined #338

Closed

garykac reviewed May 9, 2023

View reviewed changes

dlrobertson force-pushed the wheel-event-groups branch from ad9d8d3 to 8e4ac6b Compare May 10, 2023 16:00

dlrobertson commented May 10, 2023

View reviewed changes

zcorpan reviewed May 31, 2023

View reviewed changes

dlrobertson force-pushed the wheel-event-groups branch 2 times, most recently from 7531f06 to b00e1f7 Compare May 31, 2023 16:47

dlrobertson commented Jun 2, 2023

View reviewed changes

zcorpan approved these changes Jun 2, 2023

View reviewed changes

dlrobertson mentioned this pull request Jun 2, 2023

Add a scrollable container to the domeventviewer garykac/dom-event-viewer#7

Open

dlrobertson force-pushed the wheel-event-groups branch from b00e1f7 to 0315c86 Compare July 20, 2023 22:03

zcorpan approved these changes Dec 4, 2023

View reviewed changes

Specify wheel event groups

a02da34

Specify the behavior of wheel event groups.

dlrobertson force-pushed the wheel-event-groups branch from 0315c86 to a02da34 Compare December 4, 2023 15:33

garykac merged commit ee7998e into w3c:main Dec 4, 2023
2 checks passed

github-actions bot added a commit that referenced this pull request Dec 4, 2023

Merge pull request #344 from dlrobertson/wheel-event-groups

041968d

SHA: ee7998e Reason: push, by garykac Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dlrobertson deleted the wheel-event-groups branch December 4, 2023 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specify wheel event groups #344

Specify wheel event groups #344

dlrobertson commented Mar 16, 2023 •

edited

Loading

dlrobertson left a comment

dlrobertson Mar 16, 2023

garykac May 9, 2023

dlrobertson May 10, 2023

zcorpan May 31, 2023

garykac May 9, 2023

dlrobertson Jun 2, 2023

garykac May 9, 2023

garykac May 9, 2023

dlrobertson left a comment

dlrobertson May 10, 2023

zcorpan May 31, 2023

dlrobertson left a comment

dlrobertson Jun 2, 2023

dlrobertson commented Jun 27, 2023

zcorpan left a comment

dlrobertson commented Dec 4, 2023

dlrobertson commented Dec 4, 2023

Specify wheel event groups #344

Specify wheel event groups #344

Conversation

dlrobertson commented Mar 16, 2023 • edited Loading

dlrobertson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlrobertson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlrobertson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlrobertson commented Jun 27, 2023

zcorpan left a comment

Choose a reason for hiding this comment

dlrobertson commented Dec 4, 2023

dlrobertson commented Dec 4, 2023

dlrobertson commented Mar 16, 2023 •

edited

Loading