Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim dir, lang, display, orientation, text and color values #1140

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

christianliebel
Copy link
Member

@christianliebel christianliebel commented Aug 22, 2024

The three browser engines trim the dir, lang, display, orientation, text, and color values, but it is not mentioned in the specification. This PR adds this as an extra step to the algorithms that process those values.

Example:


This change (choose at least one, delete ones that don't apply):

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Implementation commitment (delete if not making normative changes):

Commit message:

Trim dir, display, orientation, text and color values

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

@christianliebel christianliebel changed the title Editorial: Trim dir, display, orientation, text and color values Editorial: Trim dir, lang, display, orientation, text and color values Sep 1, 2024
@christianliebel christianliebel changed the title Editorial: Trim dir, lang, display, orientation, text and color values Trim dir, lang, display, orientation, text and color values Sep 5, 2024
@christianliebel christianliebel merged commit 3e1fd57 into main Sep 5, 2024
2 checks passed
@christianliebel christianliebel deleted the trim branch September 5, 2024 11:30
github-actions bot added a commit that referenced this pull request Sep 5, 2024
…1140)

SHA: 3e1fd57
Reason: push, by christianliebel

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants