Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: remove “commonly” to reflect actual JSON encoding #1100

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

christianliebel
Copy link
Member

@christianliebel christianliebel commented Sep 24, 2023

Closes #1089

This change (choose at least one, delete ones that don't apply):

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Commit message:

Editorial: remove “commonly” to reflect actual JSON encoding

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

@christianliebel christianliebel marked this pull request as ready for review September 24, 2023 22:11
Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@marcoscaceres marcoscaceres merged commit 180d5df into main Nov 15, 2023
2 checks passed
@marcoscaceres marcoscaceres deleted the json-commonly branch November 15, 2023 03:47
@marcoscaceres
Copy link
Member

Sorry for the delay. Thanks for fixing this @christianliebel.

github-actions bot added a commit that referenced this pull request Nov 15, 2023
SHA: 180d5df
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON "commonly" encoded in Unicode
3 participants