Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for tts:textEmphasis='auto' #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add test for tts:textEmphasis='auto' #91

wants to merge 3 commits into from

Conversation

palemieux
Copy link
Contributor

No description provided.

@palemieux palemieux requested a review from cconcolato October 3, 2019 16:28
@palemieux palemieux self-assigned this Oct 3, 2019
cconcolato
cconcolato reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very hard to see anything on the images 0.000000.png and 0.040000.png. Can we increase the contrast? And image 0.080000.png is completely blank. Is it on purpose?
Could we add some metadata in the test to indicate what it is for?

@palemieux
Copy link
Contributor Author

It is very hard to see anything on the images 0.000000.png and 0.040000.png. Can we increase the contrast?

As requested.

Could we add some metadata in the test to indicate what it is for?

As requested.

And image 0.080000.png is completely blank. Is it on purpose?

Yes. All tests include the entire timeline, from 0s to infinity.

@palemieux palemieux requested a review from cconcolato October 22, 2019 14:08
cconcolato
cconcolato reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also have:
tts:textEmphasis='auto' (default positioning)
and
tts:textEmphasis='auto outside' (explicit positioning, equivalent to default)

@nigelmegitt
Copy link
Contributor

The contrast still looks very low to me - could we perhaps use a solid colour instead of outline, or make the outline thicker?

@nigelmegitt nigelmegitt mentioned this pull request Dec 2, 2020
Closed
Base automatically changed from master to main February 5, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato cconcolato left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@palemieux palemieux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palemieux @nigelmegitt @cconcolato