-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background and foreground color on span tests #105
base: main
Are you sure you want to change the base?
Conversation
color001: foreground color change when background present on span - illustrates how/why to keep P on a single line. color002: background color change on span color003: 2nd background color change on span - illustrates avoiding a gap. color004: background color change on span when over P with background. Note doubled opacity.
@btsimonh Are these tests specific to IMSC 1.1, or would they also work on IMSC 1.0.1? |
@btsimonh Have you validated all the proposed tests? color003 has no ID/IDREF binding for IDREF 'p1'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files should be valid and the submitter should verify that the rendering matches their expectations.
answers: |
I believe they should be good on 1.0.1? |
Any reason not to move them to IMSC1 directory then? |
Oh. I used an old version of the imscJS renderer. The most recent version does not have the artifact. I have updated #105 (comment) |
depends on if the folders repersent. Personally, I would test only against the latest tests, unless it explicitly said to test against all 3 sets? |
The tests are layered, as is the functionality required in the different versions of the IMSC specification. Tests that apply to all versions are in the IMSC1 directory, ones that apply to functionality introduced in 1.1 would be in the 1.1 directory, likewise with 1.2 etc. So a 1.2 implementation should be tested against the tests in the 1, 1.1 and 1.2 directories. |
Let me review the tests in the imsc1 folder before re-proposing any changes if required.... "The tests are layered, as is the functionality required in the different versions of the IMSC specification. Tests that apply to all versions are in the IMSC1 directory, ones that apply to functionality introduced in 1.1 would be in the 1.1 directory, likewise with 1.2 etc. So a 1.2 implementation should be tested against the tests in the 1, 1.1 and 1.2 directories." |
Raised #106 for this. |
….ttml Add copyright? Add description.
color001: foreground color change when background present on span - illustrates how/why to keep P on a single line.
color002: background color change on span
color003: 2nd background color change on span - illustrates avoiding a gap.
color004: background color change on span when over P with background. Note doubled opacity.