Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[stdlib]: fix IERC4626 signatures #4425

Merged
merged 4 commits into from
Dec 28, 2024
+6 −4
Merged

fix[stdlib]: fix IERC4626 signatures #4425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dfd2b0
fix[lib]: fix `IERC4626` signatures
charles-cooper Dec 27, 2024
04e91b3
add stdlib scope
charles-cooper Dec 27, 2024
3a89b6a
Merge branch 'master' into fix/ierc4626
charles-cooper Dec 27, 2024
0b452c8
Merge branch 'master' into fix/ierc4626
charles-cooper Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
# docs: documentation
# test: test suite
# lang: language changes
# stdlib: changes to the stdlib
# ux: language changes (UX)
# tool: integration
# ir: (old) IR/codegen changes
Expand All @@ -43,6 +44,7 @@ jobs:
docs
test
lang
stdlib
ux
tool
ir
Expand Down
8 changes: 4 additions & 4 deletions vyper/builtins/interfaces/IERC4626.vyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def previewDeposit(assets: uint256) -> uint256:
...

@external
def deposit(assets: uint256, receiver: address=msg.sender) -> uint256:
def deposit(assets: uint256, receiver: address) -> uint256:
...

@view
Expand All @@ -58,7 +58,7 @@ def previewMint(shares: uint256) -> uint256:
...

@external
def mint(shares: uint256, receiver: address=msg.sender) -> uint256:
def mint(shares: uint256, receiver: address) -> uint256:
...

@view
Expand All @@ -72,7 +72,7 @@ def previewWithdraw(assets: uint256) -> uint256:
...

@external
def withdraw(assets: uint256, receiver: address=msg.sender, owner: address=msg.sender) -> uint256:
def withdraw(assets: uint256, receiver: address, owner: address) -> uint256:
...

@view
Expand All @@ -86,5 +86,5 @@ def previewRedeem(shares: uint256) -> uint256:
...

@external
def redeem(shares: uint256, receiver: address=msg.sender, owner: address=msg.sender) -> uint256:
def redeem(shares: uint256, receiver: address, owner: address) -> uint256:
...
Loading