Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: compiler-dom as required dependency #2114

Merged
merged 1 commit into from
Jul 1, 2023
Merged

chore: compiler-dom as required dependency #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,10 @@
"vuex": "4.1.0"
},
"peerDependencies": {
"@vue/compiler-dom": "^3.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't @vue/compiler-dom still be a peer dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should, I don't know what's best. As we use it, but people don't necessarily have it installed, I was thinking that only specifying it as a dependency was maybe better.

Copy link
Collaborator

@freakzlike freakzlike Jul 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a dependency of vue so I guess it's installed anyway. Only as information for package managers (e.g. pnpm) which not install all packages flatten into node_modules

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely debate what's "techincally" correct but I'd say for 99% of people they will have it installed - how many people are using Vue without compiler-dom? Seems fine either way.

"@vue/server-renderer": "^3.0.1",
"vue": "^3.0.1"
},
"peerDependenciesMeta": {
"@vue/compiler-dom": {
"optional": true
},
"@vue/server-renderer": {
"optional": true
}
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.