Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension rule vue/quotes #2463

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add extension rule vue/quotes #2463

wants to merge 4 commits into from

Conversation

nhtnhan
Copy link

@nhtnhan nhtnhan commented May 20, 2024

FloEdelmann
FloEdelmann approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution! 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi June 19, 2024 20:19
@FloEdelmann FloEdelmann changed the title New rule vue/quotes Add extension rule vue/quotes Jun 19, 2024
ota-meshi
ota-meshi requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add test cases regarding the directives as mentioned in the comments?

#2187 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi requested changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule vue/quotes
3 participants
@nhtnhan @FloEdelmann @ota-meshi