Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: videos not being shown in productSearch query #474

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

iago1501
Copy link
Contributor

@iago1501 iago1501 commented May 10, 2024

What problem is this solving?

Product Search query not showing videos.
The info is indexed as videos, but, the catalog index with Videos. We can't simply change it because the PDP still uses the information provided by the catalog, that's why I just created another type for the search and did something to allow both types of entries

How should this be manually tested?

Workspace

curl --request POST \
  --url https://storetheme--desafioonboarding25.myvtex.com/_v/private/admin-graphql-ide/v0/[email protected] \
  --header 'Content-Type: application/json' \
  --header 'Cookie: VtexIdclientAutCookie=xxx' \
  --data '{"query":"query ($facets: [SelectedFacetInput]) {\n\tproductSearch(\n\t\tfullText: \"sku:5248\",\n\t\tselectedFacets: $facets,\n\t)\n\t{\n\t\tproducts {\n\t\t\tproductId\n\t\t\tproductName\n\t\t\tlinkText\n\t\t\titems {\n\t\t\t\titemId\n        videos {\n          videoUrl\n        }\n\t\t\t}\n\t\t}\n\t}\n}\n","variables":{"facets":[{"key":"trade-policy","value":"1"}]}}'

still returning in product context:

image

Previously:

image

image

Now returning to search query:

image

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
✔️ Technical improvements

Notes

Maybe there's another way to solve it using the compatibility layer but I'm not sure, and, since we have plans to migrate the PDP to use IS, this might be something that we can remove in the future and just keep the videos

@iago1501 iago1501 added bug Something isn't working enhancement New feature or request labels May 10, 2024
@iago1501 iago1501 requested a review from hiagolcm May 10, 2024 20:15
@iago1501 iago1501 self-assigned this May 10, 2024
Copy link

vtex-io-ci-cd bot commented May 10, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 10, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iago1501 iago1501 merged commit 5b0c808 into v1.x Jun 10, 2024
5 of 10 checks passed
@iago1501 iago1501 deleted the fix/videos branch June 10, 2024 15:12
Copy link

vtex-io-ci-cd bot commented Jun 10, 2024

Your PR has been merged! App is being published. 🚀
Version 1.69.0 → 1.70.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants