fix: videos not being shown in productSearch query #474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Product Search query not showing videos.
The info is indexed as videos, but, the catalog index with Videos. We can't simply change it because the PDP still uses the information provided by the catalog, that's why I just created another type for the search and did something to allow both types of entries
How should this be manually tested?
Workspace
still returning in product context:
Previously:
Now returning to search query:
Checklist/Reminders
README.md
.CHANGELOG.md
.Type of changes
Notes
Maybe there's another way to solve it using the compatibility layer but I'm not sure, and, since we have plans to migrate the PDP to use IS, this might be something that we can remove in the future and just keep the videos