Add #203 Lilygo S3 support #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't work on this anymore. Closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got more complex that I expected. Only because it's a mix of v7 (LCD module) and v2 that is where LIlygo started to implement their display.
Then the issue is that LEH, Latch enable signal, that is currently implemented directly in the LCD module (hsync) please correct me if I'm saying things out of the blue after my Christmas hang-over....it's still implemented using RTC in LIlygo S3 parallel solution.
So technically this is a mix of v2 and v7 boards, that is not simply copying v7 and updating some lines.
https://github.com/martinberlin/epdiy-rotation/tree/lilygos3 -> There is my working solution to implement this but I feel going backwards implementing this "as is" here. @vroland or @mickeprag maybe I will need your wise advice