Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imageconvert #271

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix imageconvert #271

merged 1 commit into from
Jan 22, 2024

Conversation

martinberlin
Copy link
Collaborator

@martinberlin martinberlin commented Dec 25, 2023

Running: python imgconvert.py is returning an error

Because it seems ANTIALIAS is not anymore a valid attribute in Pillow python module.

Traceback (most recent call last):
File "/home/martin/Documents/github/epdiy/scripts/imgconvert.py", line 20, in
im.thumbnail((args.max_width, args.max_height), Image.ANTIALIAS)
AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

Proposed solution found here:

ANTIALIAS was removed in Pillow 10.0.0 (after being deprecated through many previous versions). Now you need to use PIL.Image.LANCZOS or PIL.Image.Resampling.LANCZOS.

@martinberlin martinberlin requested a review from vroland December 25, 2023 21:36
@martinberlin martinberlin self-assigned this Dec 25, 2023
@martinberlin
Copy link
Collaborator Author

Hello @vroland
Can you please review this one line update?
Then we can merge so the new developers trying the image convert do not get this error. Thanks!

@martinberlin martinberlin added the Waiting for feedback If it's in this state more than 2 months without feedback then the Issue/MR will be closed label Jan 5, 2024
Copy link
Owner

@vroland vroland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sorry for the delay!

@martinberlin martinberlin merged commit 2803a55 into main Jan 22, 2024
24 checks passed
@vroland vroland deleted the fix/imageconvert branch May 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for feedback If it's in this state more than 2 months without feedback then the Issue/MR will be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants