Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voxpupuli-rubocop: Pin to patch version #161

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

bastelfreak
Copy link
Member

We do this on all other projects as well. New minor version might pull in new rubocop versions. To ensure that we test those in a PR, we pin to the patch release. dependabot will inform us about updates.

@bastelfreak bastelfreak self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb35a8d) 95.20% compared to head (10b4ad5) 95.20%.

❗ Current head 10b4ad5 differs from pull request most recent head 200cbb7. Consider uploading reports for the commit 200cbb7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files           2        2           
  Lines         167      167           
=======================================
  Hits          159      159           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zilchms
Copy link

zilchms commented Jan 30, 2024

Seems we are one bundle exec short.
"Run the puppet_versions:update task to update it and commit the changes."
Otherwise LGTM

We do this on all other projects as well. New minor version might pull
in new rubocop versions. To ensure that we test those in a PR, we pin to
the patch release. dependabot will inform us about updates.
@bastelfreak bastelfreak merged commit 58358b1 into voxpupuli:master Jan 30, 2024
6 checks passed
@bastelfreak bastelfreak deleted the voxpupuli-rubocop branch January 30, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants