Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to using the nodistro nodesource repos, removing source support, dropping support for NodeJS16 on EL9 #485

Merged
merged 3 commits into from
Jan 3, 2024
Merged

switch to using the nodistro nodesource repos, removing source support, dropping support for NodeJS16 on EL9 #485

merged 3 commits into from
Jan 3, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 28, 2023 •
edited
Loading

the other ones do not contain the latest releases
(e.g. 20.x contains 20.5 vs 20.9)

this removes the repo_enable_src and repo_release parameters, as they are not useful anymore.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@evgeni evgeni changed the title switch to using the nodistro nodesource repos switch to using the nodistro nodesource repos, removing source support Oct 28, 2023
@evgeni
Copy link
Member Author

evgeni commented Oct 28, 2023

🤦‍♀️
the nodistro packages are signed by SHA1, but that obviously doesn't work for EL9: nodesource/distributions#1693

@evgeni evgeni force-pushed the nodistro branch 2 times, most recently from 5ff0a2e to 831f4b8 Compare October 28, 2023 16:53
@evgeni evgeni force-pushed the nodistro branch 2 times, most recently from 02ce29a to 31eb4ba Compare October 28, 2023 17:30
@evgeni
Copy link
Member Author

evgeni commented Oct 28, 2023 •
edited
Loading

Node EL8 EL9 nodistro
16 16.20.2 16.20.2 16.20.2
18 18.17.1 18.17.1 18.18.2
20 20.5.1 20.5.1 20.9.0 
# for rel in 16 18 20; do dnf repoquery --repo nodesource --repofrompath nodesource,https://rpm.nodesource.com/pub_${rel}.x/nodistro/nodejs/x86_64 --latest 1; done
Added nodesource repo from https://rpm.nodesource.com/pub_16.x/nodistro/nodejs/x86_64
nodesource                                                                                                                                                                                             878 kB/s | 732 kB     00:00    
Last metadata expiration check: 0:00:01 ago on Sat Oct 28 17:43:53 2023.
nodejs-2:16.20.2-1nodesource.x86_64
nodejs-devel-2:16.20.2-1nodesource.x86_64
nodejs-docs-2:16.20.2-1nodesource.noarch
Added nodesource repo from https://rpm.nodesource.com/pub_18.x/nodistro/nodejs/x86_64
nodesource                                                                                                                                                                                             1.7 MB/s | 750 kB     00:00    
nodejs-2:18.18.2-1nodesource.x86_64
nodejs-devel-2:18.18.2-1nodesource.x86_64
nodejs-docs-2:18.18.2-1nodesource.noarch
Added nodesource repo from https://rpm.nodesource.com/pub_20.x/nodistro/nodejs/x86_64
Last metadata expiration check: 0:00:24 ago on Sat Oct 28 17:43:30 2023.
nodejs-2:20.9.0-1nodesource.x86_64
nodejs-devel-2:20.9.0-1nodesource.x86_64
nodejs-docs-2:20.9.0-1nodesource.noarch

# for rel in 16 18 20; do dnf repoquery --repo nodesource --repofrompath nodesource,https://rpm.nodesource.com/pub_${rel}.x/el/8/x86_64 --latest 1; done
Added nodesource repo from https://rpm.nodesource.com/pub_16.x/el/8/x86_64
nodesource                                                                                                                                                                                             1.7 MB/s | 710 kB     00:00    
nodejs-2:16.20.2-1nodesource.x86_64
nodejs-devel-2:16.20.2-1nodesource.x86_64
nodejs-docs-2:16.20.2-1nodesource.noarch
nodesource-release-0:el8-1.noarch
Added nodesource repo from https://rpm.nodesource.com/pub_18.x/el/8/x86_64
nodesource                                                                                                                                                                                             2.5 MB/s | 653 kB     00:00    
nodejs-2:18.17.1-1nodesource.x86_64
nodejs-devel-2:18.17.1-1nodesource.x86_64
nodejs-docs-2:18.17.1-1nodesource.noarch
nodesource-release-0:el8-1.noarch
Added nodesource repo from https://rpm.nodesource.com/pub_20.x/el/8/x86_64
nodesource                                                                                                                                                                                             427 kB/s | 232 kB     00:00    
nodejs-2:20.5.1-1nodesource.x86_64
nodejs-devel-2:20.5.1-1nodesource.x86_64
nodejs-docs-2:20.5.1-1nodesource.noarch
nodesource-release-0:el8-1.noarch

# for rel in 16 18 20; do dnf repoquery --repo nodesource --repofrompath nodesource,https://rpm.nodesource.com/pub_${rel}.x/el/9/x86_64 --latest 1; done
Added nodesource repo from https://rpm.nodesource.com/pub_16.x/el/9/x86_64
nodesource                                                                                                                                                                                             673 kB/s | 280 kB     00:00    
nodejs-2:16.20.2-1nodesource.x86_64
nodejs-devel-2:16.20.2-1nodesource.x86_64
nodejs-docs-2:16.20.2-1nodesource.noarch
nodesource-release-0:el9-1.noarch
Added nodesource repo from https://rpm.nodesource.com/pub_18.x/el/9/x86_64
nodesource                                                                                                                                                                                             1.1 MB/s | 653 kB     00:00    
nodejs-2:18.17.1-1nodesource.x86_64
nodejs-devel-2:18.17.1-1nodesource.x86_64
nodejs-docs-2:18.17.1-1nodesource.noarch
nodesource-release-0:el9-1.noarch
Added nodesource repo from https://rpm.nodesource.com/pub_20.x/el/9/x86_64
nodesource                                                                                                                                                                                             281 kB/s | 232 kB     00:00    
nodejs-2:20.5.1-1nodesource.x86_64
nodejs-devel-2:20.5.1-1nodesource.x86_64
nodejs-docs-2:20.5.1-1nodesource.noarch
nodesource-release-0:el9-1.noarch

@evgeni evgeni force-pushed the nodistro branch 3 times, most recently from 2f7c55e to a8255b9 Compare October 28, 2023 18:23
evgeni
evgeni commented Oct 28, 2023
View reviewed changes
files/repo/nodesource/NODESOURCE-GPG-SIGNING-KEY-EL
@@ -1,29 +1,30 @@
-----BEGIN PGP PUBLIC KEY BLOCK-----
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have a static key block for RPM, but Debian uses a remote URL? is it because there we can still pin the fingerprint of the key?

@evgeni evgeni force-pushed the nodistro branch 3 times, most recently from 2d987ce to c505176 Compare October 30, 2023 10:52
@evgeni evgeni force-pushed the nodistro branch 5 times, most recently from 75e56e7 to d7457b9 Compare January 3, 2024 08:30
evgeni added 3 commits January 3, 2024 09:37
@evgeni
switch to using the nodistro nodesource repos
7649b6b 
the other ones do not contain the latest releases
(e.g. 20.x contains 20.5 vs 20.9)
@evgeni
use new key for 18+
809be69
@evgeni
skip NodeJS16 on EL9
ea16ac7
@evgeni evgeni marked this pull request as ready for review January 3, 2024 08:52
@evgeni evgeni changed the title switch to using the nodistro nodesource repos, removing source support switch to using the nodistro nodesource repos, removing source support, dropping support for NodeJS16 on EL9 Jan 3, 2024
@evgeni evgeni merged commit 8bc3059 into master Jan 3, 2024
85 checks passed
@evgeni evgeni deleted the nodistro branch January 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @bastelfreak