pid directory mode needs be writable

[ashish1099]

Employer EnableIT

If file resource is defined globally, its fails to start the elasticsearch process. so getting the mode set in first place is a right way to do it.

File { owner => root, group => root, mode => '0444' }

[tylerjl]

Thanks for the contribution! This looks like a great change, once you sign the CLA this should be good to go.

[ashish1099]

I have signed the CLA

[tylerjl]

Thanks for getting the CLA taken care of, @ashish1099. Can you merge in the latest changes in master into your PR? It's been a couple of months so there are several testing changes (and there are conflicts in config.pp)

[ashish1099]

@tylerjl I have fixed it.
It was quite a fun, since I got messed up my local branch.

[tylerjl]

Thanks for solving that mess @ashish1099 😄

It looks like the failures in Travis CI are legitimate. If you look at one of the failed tests you'll see that the puppet runs that test for idempotency are failing (that is, the second time puppet runs it still makes changes to the system so something either isn't being set right the first time or something on the system is changing the permissions after running puppet). I'm not entirely what this may be (since it happens on both SysV and systemd-based systems), so you may have to work with it to find what exactly is going on.

[fatmcgav]

Hi there,

Firstly, thank you for taking the time to contribute, and apologies for the radio silence from Elastic on this PR.

I'm going to be working on this module over the next few weeks, with an ultimate aim of updating the module to support the elasticsearch 7.x and simplifying the module to make it easier to use.

I'll be reviewing all the open issues and PRs over the next few days, and will merge or provide feedback where appropriate.

So please hang in there whilst we give this module some TLC.

Thanks again.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[vox-pupuli-tasks]

Dear @ashish1099, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[vox-pupuli-tasks]

Dear @ashish1099, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks