-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger on peak RSSI #87
Conversation
Trigger on peak RSSI
Unfortunately this approach won't improve anything as it's too straightforward. The RSSI values are read once per 0.1ms and can vary sensibly (around 2-3 for subsequent reads). |
Improved slope detection algorithm Simple filter for rssi readings added
Thank you for feedback. I tried to improve. Will test further |
Increased rssi readings for slope detection
Improved rssi peak detection
I have made some changes to peak detection algorithm. Tested, and looks like it's works quite good. Andrey could you take a look at it? |
Thanks for your effort. The code seems ok, but I'm not sure it's really needed. If it behaves the same both with this fix and without it, then I'd avoid unnecessary code complication. |
Triggering on peak RSSI should give much improved tracking accuracy, When measuring via peak detection, both laps will be be counted equally , as the peak will be at the same moment, albeit a little higher or lower. This might make 'only' 10-100ms difference, but in droneracing 100ms is a LOT. |
@StarrrLiteNL I somewhat agree, but have you seen the RSSI signal in real time? Believe me, there's no clean peak or nice smooth transition from low to high when approaching the timer. The suggested approach might improve things a bit, but also might make them a bit worse. But most likely it won't change anything significantly. So I'd avoid making changes to the detection algorithm until they are proved to benefit the accuracy. As for other timers, don't they really use a threshold? Then how would they detect false peaks if a drone flies on some distance from the timer? |
I'm used modified chorus firmware with peak detection, for about half year. It works good, at lest not worse than standard :) I'm not sure if it makes big improvement comparing standard firmware. Still need to be tweaked. I'm not sure if ~3ms is enough to detect peak. Possible that SLOPE_DETECTION_ITERATIONS should be increased. |
@voroshkov , they threshold and peak. Once a channel passes the threshold, it will keep measuring untill it falls below it , and then takes the peak value for time measurement. |
@StarrrLiteNL, exactly! |
Don't get me wrong, I agree with the idea, but need good implementation for it, which will maintain balance between instant tracking and accuracy. |
Added fake read to improve analog readings accuracy (as suggested by Nicola Gorghetto)
Trigger on peak RSSI #64