Make "collections" feature optional #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Er, why do we need this? Is it common that someone would depend on There's no actual code / support for these in the crate, these just… manipulate the dependencies this crate doesn't really need… |
|
For the most part, you’re correct, but I wanted to provide an option to disable the “collections” feature. And also in #15, bumpalo-herd also depends on “allocator_api” and “allocator-api2,” so I exposed the feature flags in this way. |
|
I have just closed PR #15, so perhaps you are correct that this patch is unnecessary, except for making the “collection” feature optional. I'll change the PR. |
simnalamburt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows bumpalo-herd users to freely enable and disable various feature flags of bumpalo.