Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gha new container 2 #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gha new container 2 #63

wants to merge 1 commit into from

Conversation

vmcj
Copy link
Owner

@vmcj vmcj commented Jun 14, 2024

No description provided.

@vmcj vmcj force-pushed the gha_new_container_2 branch 11 times, most recently from 6a12c90 to b192973 Compare June 16, 2024 11:48
The job used the baseinstall script which does the setup of a whole installation
but we only need composer for phpstan.

I've removed & renamed that script as it wasn't used anywhere else. In
the future we can add the relevant sections again and toggle the needed
steps to make sure we don't replicate the needed steps. For example the
unit tests don't need a judgehost installed, neither do the webstandard
jobs.

Another solution would have been to use our container but as we need
docker there and some other parts (phpstan action builds it own
container inside ours in that case) this was the easier solution.

The different shell functions are now fully POSIX complaint as we ran
with bash first together with some aliases which we can't easily expand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant