-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Java metamodel #276
base: main
Are you sure you want to change the base?
New Java metamodel #276
Conversation
JavaClasspath.registerZIP(URI) - Removed references to JavaClasspath.Initializer as it does not exist anymore - Replaced JavaClasspath.getClassifier(String) with JavaClasspath.getConcreteClassifier(String)
- Moved the call-part of the JavaCompilationUnitInsertedInPackage reaction into the JavaCompilationUnitInsertedAsRoot reaction - JavaContainerAndClassifierUtil - Simplified methods removeJavaClassifierFromPackage()and findClassifier()
- Replaced calls to Package.compilationUnits with Package.classifiers.map[it.containingCompilationUnit] - JaMoPPTest - Corrected the means of adding a CompilationUnit to a Package
- Renamed reactions to comply with naming conventions - "PackageCreated" -> "JavaPackageCreated" - "InterfaceCreated" -> "JavaInterfaceCreated" - "ClassCreated" -> "JavaClassCreated" -JaMoPPTest.java - testAddInterfaceMethod() - Added an empty statement to the interface method to avoid NullPointerExceptions
also created and added
- Added a check to initializeClassMethod() to avoid the statement of the method being null
include a statement => PCM-Java tests now do show the same results as before the MM change
- Fixed a bug in reaction JavaCompilationUnitInsertedAsRoot
=> UML-Java tests now show even better results than before the MM change
- Updated JaMoPP repository reference in parent pom => UML-Java tests now show even better results than before the MM change
Thank you very much for your contribution 👍 |
Tycho build and added them to the .gitignore
The old jamopp metamodel is still used in the commonalities projects. @tschilpp do you plan to migrate them also? |
Until now, I wasn't even aware that the old MM was used elsewhere. At the beginning of my practical course, I was told to migrate the transformation (UML <-> Java and PCM <-> Java) to the new MM and make sure that the tests show the same results as before the migration. So in short the answer is probably not. |
That's absolutely fine, I just wanted to make sure no work is done twice. I will adapt this PR to pass the CI (if that is ok for you @tschilpp ?) and open an issue for the migration of the commonalities projects. |
- Added the missing creation of a block
Updated the Java metamodel used in the case studies from the old Java 6 version to the new Java 15 declared in JaMoPP.