-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Handle --vreplication_experimental_flags options properly for partial images #17428
Merged
mattlord
merged 1 commit into
vitessio:main
from
planetscale:vrepl_efficient_repl_followup
Dec 25, 2024
Merged
VReplication: Handle --vreplication_experimental_flags options properly for partial images #17428
mattlord
merged 1 commit into
vitessio:main
from
planetscale:vrepl_efficient_repl_followup
Dec 25, 2024
+39
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlord
requested review from
harshit-gangal,
systay,
shlomi-noach,
rohit-nayak-ps and
timvaillancourt
as code owners
December 24, 2024 17:11
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 24, 2024
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 24, 2024
mattlord
force-pushed
the
vrepl_efficient_repl_followup
branch
2 times, most recently
from
December 24, 2024 17:44
fd3b43d
to
28adbec
Compare
mattlord
changed the title
VReplication: Handle --vreplication_experimental_flags options properly
VReplication: Handle --vreplication_experimental_flags options properly for partial images
Dec 24, 2024
mattlord
force-pushed
the
vrepl_efficient_repl_followup
branch
from
December 24, 2024 18:10
28adbec
to
ebc71af
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vrepl_efficient_repl_followup
branch
from
December 24, 2024 18:16
ebc71af
to
df3171e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17428 +/- ##
==========================================
- Coverage 67.68% 67.66% -0.02%
==========================================
Files 1583 1583
Lines 254321 254319 -2
==========================================
- Hits 172131 172079 -52
- Misses 82190 82240 +50 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
approved these changes
Dec 25, 2024
rohit-nayak-ps
approved these changes
Dec 25, 2024
notfelineit
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick follow-up to #17345
In backporting this in a fork, where the
--vreplication_experimental_flags
were being handled differently — 1) the noblob support was disabled in all unit tests except the noblob ones 2) vplayer batching was not enabled — I noticed some incorrect behavior.Those fixes and adjustments are made here.
Related Issue(s)
Checklist