-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang.org/x/net from 0.31.0 to 0.33.0 #17416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses: https://github.com/vitessio/vitess/security/dependabot/400 Signed-off-by: Matt Lord <[email protected]>
mattlord
added
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
labels
Dec 19, 2024
mattlord
requested review from
ajm188,
deepthi,
harshit-gangal,
rohit-nayak-ps,
systay and
frouioui
as code owners
December 19, 2024 23:04
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 19, 2024
mattlord
added
Security
Type: Dependencies
Dependency updates
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 19, 2024
dbussink
approved these changes
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17416 +/- ##
==========================================
- Coverage 67.65% 67.63% -0.03%
==========================================
Files 1581 1581
Lines 253775 253775
==========================================
- Hits 171694 171631 -63
- Misses 82081 82144 +63 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
timvaillancourt
pushed a commit
that referenced
this pull request
Dec 23, 2024
…17420) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
timvaillancourt
pushed a commit
that referenced
this pull request
Dec 23, 2024
…17421) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
timvaillancourt
pushed a commit
that referenced
this pull request
Dec 23, 2024
…17422) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
Component: General
Changes throughout the code base
Security
Type: Dependencies
Dependency updates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses: https://github.com/vitessio/vitess/security/dependabot/400
I'm not sure why Dependabot failed to open a PR (N times)... perhaps we have a permission issue or something. Nothing obvious from the logs.
The bug is in the
x/net/html
package that we don't actually use in Vitess. The only place we usex/net
at all is in some unit tests:Related Issue(s)
Checklist
Deployment Notes