Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export BuildSummary func for VDiff show #17413

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

beingnoble03
Copy link
Member

@beingnoble03 beingnoble03 commented Dec 19, 2024

Description

This PR exports BuildSummary function that generates a summary from a VDiff show response.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Noble Mittal <[email protected]>
Copy link
Contributor

vitess-bot bot commented Dec 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 19, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 85.32609% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (45192d2) to head (84ead7b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/vdiff.go 85.71% 26 Missing ⚠️
go/vt/vtadmin/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17413      +/-   ##
==========================================
+ Coverage   67.52%   67.61%   +0.08%     
==========================================
  Files        1581     1582       +1     
  Lines      253948   253945       -3     
==========================================
+ Hits       171480   171694     +214     
+ Misses      82468    82251     -217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beingnoble03 beingnoble03 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 20, 2024
@beingnoble03 beingnoble03 marked this pull request as ready for review December 20, 2024 11:49
@beingnoble03 beingnoble03 changed the title Export VDiff Show Summary Export BuildSummary func for VDiff show Dec 20, 2024
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @beingnoble03 ! ❤️

/cc @mdlayher

@mdlayher
Copy link
Member

Thank you very much @beingnoble03!

@rohit-nayak-ps rohit-nayak-ps merged commit dd4ec2e into vitessio:main Dec 21, 2024
108 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants