-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the release workflow #16964
Merged
Merged
Fix the release workflow #16964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 15, 2024
frouioui
added
Backport to: release-21.0
Needs to be backport to release-21.0
Type: Bug
Component: Build/CI
Type: Release
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 15, 2024
Signed-off-by: Florent Poinsard <[email protected]> WIP - Move setup node to the beginning of the workflow Signed-off-by: Florent Poinsard <[email protected]> WIP - test workflow Signed-off-by: Florent Poinsard <[email protected]> WIP - test workflow Signed-off-by: Florent Poinsard <[email protected]> WIP - remove test workflow and remove node setup from release workflow Signed-off-by: Florent Poinsard <[email protected]> WIP - Correct upload URL Signed-off-by: Florent Poinsard <[email protected]> WIP - Correct upload URL Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
fix-release-workflow
branch
from
October 15, 2024 22:14
b175de6
to
f72c482
Compare
frouioui
requested review from
deepthi,
mattlord and
rohit-nayak-ps
as code owners
October 15, 2024 22:16
deepthi
approved these changes
Oct 21, 2024
GuptaManan100
approved these changes
Oct 21, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Build/CI
Type: Bug
Type: Release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the release workflow that build and push the release artefacts to a new release. This failed very recently as we released
v21.0.0-rc1
: https://github.com/vitessio/vitess/actions/runs/11339640858. As of nowv21.0.0-rc1
does not have any release artefacts attached to it.The problem is that we are attempting to read
go.mod
before checking out the source code. This bug was introduced by #16841Since we will not be able to re-trigger the workflow on a
release
gh event (we can only on branch/tags), and the workflow we use depend on that, I am going to modify the workflow in another commit to allow it to run from this PR and build+push the release artefacts, that way everything is done within CI and not done manually.As we changed the workflows in v21 too, let's backport this to v21 to avoid the same issue for future releases.
Building/Pushing
v21.0.0-rc1
artefactsCommit
cc0780c
(#16964) is a squash of all the commits I had to push to get the workflow running correctly, the last commit of this squash (b175de6) uploaded the release artefacts correctly as seen on https://github.com/vitessio/vitess/releases/tag/v21.0.0-rc1