Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the release workflow #16964

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Fix the release workflow #16964

merged 3 commits into from
Oct 21, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 15, 2024

Description

This PR fixes the release workflow that build and push the release artefacts to a new release. This failed very recently as we released v21.0.0-rc1: https://github.com/vitessio/vitess/actions/runs/11339640858. As of now v21.0.0-rc1 does not have any release artefacts attached to it.

The problem is that we are attempting to read go.mod before checking out the source code. This bug was introduced by #16841

Since we will not be able to re-trigger the workflow on a release gh event (we can only on branch/tags), and the workflow we use depend on that, I am going to modify the workflow in another commit to allow it to run from this PR and build+push the release artefacts, that way everything is done within CI and not done manually.

As we changed the workflows in v21 too, let's backport this to v21 to avoid the same issue for future releases.

Building/Pushing v21.0.0-rc1 artefacts

Commit cc0780c (#16964) is a squash of all the commits I had to push to get the workflow running correctly, the last commit of this squash (b175de6) uploaded the release artefacts correctly as seen on https://github.com/vitessio/vitess/releases/tag/v21.0.0-rc1

Signed-off-by: Florent Poinsard <[email protected]>
Copy link
Contributor

vitess-bot bot commented Oct 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 15, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 15, 2024
@frouioui frouioui added Backport to: release-21.0 Needs to be backport to release-21.0 Type: Bug Component: Build/CI Type: Release and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 15, 2024
Signed-off-by: Florent Poinsard <[email protected]>

WIP - Move setup node to the beginning of the workflow

Signed-off-by: Florent Poinsard <[email protected]>

WIP - test workflow

Signed-off-by: Florent Poinsard <[email protected]>

WIP - test workflow

Signed-off-by: Florent Poinsard <[email protected]>

WIP - remove test workflow and remove node setup from release workflow

Signed-off-by: Florent Poinsard <[email protected]>

WIP - Correct upload URL

Signed-off-by: Florent Poinsard <[email protected]>

WIP - Correct upload URL

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the fix-release-workflow branch from b175de6 to f72c482 Compare October 15, 2024 22:14
@frouioui frouioui marked this pull request as ready for review October 15, 2024 22:16
@frouioui frouioui merged commit 4522a0a into main Oct 21, 2024
189 checks passed
@frouioui frouioui deleted the fix-release-workflow branch October 21, 2024 15:58
vitess-bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: Florent Poinsard <[email protected]>
frouioui pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants