Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-15.0] Fix: convertBoolToSemiSyncAction method to account for all semi sync actions (#13075) #13957

Merged

Conversation

arthurschreiber
Copy link
Contributor

Description

This is a backport of #13075.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 12, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 12, 2023
@arthurschreiber arthurschreiber changed the base branch from main to release-15.0 September 12, 2023 12:14
@github-actions github-actions bot added this to the v18.0.0 milestone Sep 12, 2023
@arthurschreiber arthurschreiber added Type: Bug Component: Cluster management Backport This is a backport and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 12, 2023
@arthurschreiber arthurschreiber modified the milestones: v18.0.0, v15.0.5 Sep 12, 2023
@github-actions github-actions bot modified the milestones: v15.0.5, v18.0.0 Sep 14, 2023
@arthurschreiber arthurschreiber modified the milestones: v18.0.0, v15.0.5 Sep 14, 2023
…actions (vitessio#13075)

* Fix convertBoolToSemiSyncAction method to account for all semi sync actions

Signed-off-by: William Lu <[email protected]>
Signed-off-by: William Lu <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
@arthurschreiber arthurschreiber force-pushed the arthur/backport-semi-sync-fixes-v15 branch from 6a46fa0 to 904918e Compare September 14, 2023 07:42
@frouioui frouioui merged commit ebbf009 into vitessio:release-15.0 Sep 20, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants