Merge pull request #3 from villagelabsco/hotfix/signing-key-bug

hotfix: crash from signing keybug
villagelabsco · Oct 31, 2024 · 5104c59 · 5104c59
2 parents 7458621 + 2c80458
commit 5104c59
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tap_github/client.py b/tap_github/client.py
@@ -256,8 +256,8 @@ def generate_jwt(self) -> str:
         env_github_jwt_signing_key = os.getenv("TAP_GITHUB_SIGNING_KEY")
         env_client_id = os.getenv("TAP_GITHUB_CLIENT_ID")
 
-        signing_key = self.config["signing_key"] or env_github_jwt_signing_key
-        client_id = self.config["client_id"] or env_client_id
+        signing_key = self.config.get("signing_key", None) or env_github_jwt_signing_key
+        client_id = self.config.get("client_id", None) or env_client_id
 
         payload = {
             # Issued at time