Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop overriding Wrapper meta #160

Merged
merged 7 commits into from
Dec 28, 2024
Merged

fix: stop overriding Wrapper meta #160

merged 7 commits into from
Dec 28, 2024

Conversation

brillout
Copy link
Member

@phonzammi Let's do this for the other packages as well. I quickly tried and it seems to work, but please double check whether this works.

@phonzammi
Copy link
Member

Let me take a look

@phonzammi
Copy link
Member

I’ve pushed a commit to test if the Wrapper is still loaded on the client side, and it turns out it is.

@brillout
Copy link
Member Author

Let me have a look

@brillout
Copy link
Member Author

Fixed

@brillout
Copy link
Member Author

Let's then also bump vike: '>=0.4.203', to 211 in the config.js files.

@phonzammi
Copy link
Member

Fixed

Indeed, awesome 💯

Let's then also bump vike: '>=0.4.203', to 211 in the config.js files.

I'll do it

@phonzammi
Copy link
Member

Done. Let me know if the commit messages look good

@brillout
Copy link
Member Author

LGTM 💫 We can merge & release.

@phonzammi phonzammi merged commit f327a5a into main Dec 28, 2024
7 checks passed
@phonzammi phonzammi deleted the brillout/dev branch December 28, 2024 18:51
@phonzammi
Copy link
Member

vike-react-{antd|styled-components|styled-jsx} has been released as version 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants