Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a global event ID counter on Windows #243

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Use a global event ID counter on Windows #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions source/eventcore/drivers/winapi/events.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ final class WinAPIEventDriverEvents : EventDriverEvents {
EventSlot[EventID] m_events;
CRITICAL_SECTION m_mutex;
ConsumableQueue!Trigger m_pending;
uint m_idCounter;
static shared uint m_idCounter;
}

this(WinAPIEventDriverCore core)
Expand Down Expand Up @@ -70,8 +70,10 @@ final class WinAPIEventDriverEvents : EventDriverEvents {

override EventID create()
{
auto id = EventID(m_idCounter++, 0);
if (id == EventID.invalid) id = EventID(m_idCounter++, 0);
import core.atomic : atomicOp;

auto id = EventID(atomicOp!"+="(m_idCounter, 1), 0);
if (id == EventID.invalid) id = EventID(atomicOp!"+="(m_idCounter, 1), 0);
m_events[id] = EventSlot(1, new ConsumableQueue!EventCallback); // FIXME: avoid GC allocation
debug (EventCoreLeakTrace) {
import core.runtime : defaultTraceHandler;
Expand Down