DATA-3444 Add exportTabularData to data client #428
Conversation
src/app/data-client.ts
Outdated
| resourceName: string; | ||
| resourceSubtype: string; | ||
| methodName: string; | ||
| timeCaptured: Date; |
There was a problem hiding this comment.
per failing tests, I think this needs to be Date | undefined since it's possible no timeCaptured exists on the response.
There was a problem hiding this comment.
I didn't realize we had to account for that with protobuf! Noted
| methodName: string, | ||
| startTime?: Date, | ||
| endTime?: Date | ||
| ) { |
There was a problem hiding this comment.
@stuqdog Wondering if I should change this to return AsyncIterableIterator<TabularDataPoint>. Thoughts?
There was a problem hiding this comment.
Hmm... I suspect we need to be awaiting ourselves either way to convert into a TabularDataPoint (or get into some funky async functional mapping). I guess that might be useful if someone just wants to stream all tabular data as it continues to come in? That seems like it adds more complexity/work to users so my thought is no, but there may be a use case I'm not thinking about (could someone use that to tail all data as it comes in? is that a use case we expect to be common?).
tl;dr weakly I support keeping as-is but open to being convinced otherwise.
There was a problem hiding this comment.
I'm thinking of the use case where someone wants to retrieve a lot of data. Possibly even download it as a file
This PR adds the new Data endpoint ExportTabularData to the typescript SDK.