[RSDK-9433] - Store TLS certs in DER format to save space #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjperez
approved these changes
Dec 11, 2024
Comment on lines
+6
to
+7
| use rustls_pki_types::pem::PemObject; | ||
| use rustls_pki_types::{CertificateDer, PrivateKeyDer}; |
Comment on lines
+448
to
+449
| let _ = self.srv_cert.replace(srv_cert); | ||
| let _ = self.srv_key.replace(srv_key); |
Comment on lines
+457
to
+458
| &self.srv_cert.as_ref().unwrap(), | ||
| &self.srv_key.as_ref().unwrap(), |
There was a problem hiding this comment.
nit: ? instead of unwrap since the return signature is compatible
Comment on lines
+31
to
+32
| let priv_keys = rustls::PrivateKey(self.srv_key.clone().unwrap()); | ||
| let cert_chain = vec![rustls::Certificate(self.srv_cert.clone().unwrap())]; |
| fn try_from(resp: CertificateResponse) -> Result<Self, Self::Error> { | ||
| // we convert the certificate and private key from PEM to DER format to save space | ||
| let private_key_bytes = resp.tls_private_key.into_bytes(); | ||
| let private_key = PrivateKeyDer::from_pem_slice(&private_key_bytes[0..])?; |
There was a problem hiding this comment.
this range should just work with [..] right? also, maybe check if the range is needed or if as_slice is available.
L102 does the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.