chore: fastify auth layer implementation #3465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,5 @@ | |||
| export function getVersionFromTarball(name: string): string | void { | |||
| const groups = name.match(/.+-(\d.+)\.tgz/); | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
There was a problem hiding this comment.
^.+-(\d.+)\.tgz should avoid this issue
|
good progress. looking forward to taking it out for a test drive |
|
Thanks :) baby steps for removing express. |
juanpicado
force-pushed
the
jota/fastify-migration
branch
from
aa2ce35 to
f184e0b
Compare
| @@ -0,0 +1,5 @@ | |||
| export function getVersionFromTarball(name: string): string | void { | |||
| const groups = name.match(/^.+-(\d.+)\.tgz/); | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
There was a problem hiding this comment.
Here's a safe regex (according to recheck) that is also more precise 😃
/-(\d+\.\d+\.\d+)\.tgz$/
juanpicado
force-pushed
the
jota/fastify-migration
branch
from
f184e0b to
46df423
Compare
juanpicado
force-pushed
the
jota/fastify-migration
branch
from
46df423 to
838d676
Compare
juanpicado
force-pushed
the
jota/fastify-migration
branch
from
838d676 to
9bc3232
Compare
chore: fastify auth layer implementation
juanpicado
force-pushed
the
jota/fastify-migration
branch
from
9bc3232 to
513407a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step for #2623