-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade resvg to ^2.6.0 & refine mask-image #572
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oops! vercel deploy failed. |
You're welcome, my pleasure. |
any update? |
I might try a custom build of Resvg.js as its latest WASM build is 1.1MB larger than old versions. My guess is that it includes font loading / WASI related features that Satori doesn't actually need. |
Is satori currently sensitive to wasm file size? I would consider releasing a smaller size |
Yes, we would like https://vercel.com/docs/functions/limitations |
Would love to see this merged, we've got a panic at the moment that is fixed in resvg upstream but not in the version bundled with satori. |
any updates on this? 🚀 🙏🏼 |
@adamJLev We ended up needing to fork this project since vercel has set an arbitrary requirement for their version which is largely irrelevant for everyone else's use case. |
cool! I also ended up working around it by using the image scaler to get the image always as PNG for satori. |
Any update on the smaller size |
@resvg/resvg-js
to ^2.6.0mask-type
toalpha
to match the effect of browserresvg
behaviour, see Cannot render svg with image on2.4.1
thx/resvg-js#257 (comment) (Need more work)CC @shuding @LuciNyan