Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade resvg to ^2.6.0 & refine mask-image #572

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jackie1210
Copy link
Contributor

@Jackie1210 Jackie1210 commented Nov 6, 2023

CC @shuding @LuciNyan

@Jackie1210 Jackie1210 requested a review from shuding as a code owner November 6, 2023 15:22
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ❌ Failed (Inspect) Nov 6, 2023 3:26pm

@Jackie1210
Copy link
Contributor Author

Oops! vercel deploy failed.

@Jackie1210
Copy link
Contributor Author

Huge thanks to @yisibl and @zimond for their hard work on @resvg/resvg-js!

@yisibl
Copy link
Contributor

yisibl commented Nov 6, 2023

You're welcome, my pleasure.

@ppjjzz
Copy link

ppjjzz commented Dec 1, 2023

any update?

@shuding
Copy link
Member

shuding commented Jan 18, 2024

I might try a custom build of Resvg.js as its latest WASM build is 1.1MB larger than old versions. My guess is that it includes font loading / WASI related features that Satori doesn't actually need.

@yisibl
Copy link
Contributor

yisibl commented Jan 18, 2024

I might try a custom build of Resvg.js as its latest WASM build is 1.1MB larger than old versions. My guess is that it includes font loading / WASI related features that Satori doesn't actually need.

Is satori currently sensitive to wasm file size? I would consider releasing a smaller size @resvg/resvg-wasm package if needed.

@styfle
Copy link
Member

styfle commented Feb 7, 2024

Is satori currently sensitive to wasm file size?

Yes, we would like satori to continue working with the 1 MB gzip size limit for Hobby customers using Edge Functions.

https://vercel.com/docs/functions/limitations

image

@woodhull
Copy link

Would love to see this merged, we've got a panic at the moment that is fixed in resvg upstream but not in the version bundled with satori.

@adamJLev
Copy link

adamJLev commented Oct 6, 2024

any updates on this? 🚀 🙏🏼

@woodhull
Copy link

@adamJLev We ended up needing to fork this project since vercel has set an arbitrary requirement for their version which is largely irrelevant for everyone else's use case.

@adamJLev
Copy link

@adamJLev We ended up needing to fork this project since vercel has set an arbitrary requirement for their version which is largely irrelevant for everyone else's use case.

cool!

I also ended up working around it by using the image scaler to get the image always as PNG for satori.
This might be a decent workaround for other people that have webp images and need to render them in satori somehow

@peterfritz
Copy link

Any update on the smaller size @resvg/resvg-wasm package, @yisibl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mask image render incorrect
8 participants