Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues 380 and 365: Editor issues and infinite network requests in Edit Post #387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vivek7405
Copy link

closes #365
closes #380

  1. Fixed infinite network requests in Edit Post page.
  2. Fixed Editor issues:
  • Content saved in editor for one post was appearing in editor for another post due to localstorage. Disabled localstorage in Novel editor to resolve the issue.
  • Title and subtitle were not auto-saving. Fixed the issue by adding a useEffect that auto-saves all the editor content including title and sub-title.

1. Content saved in editor for one post was appearing in editor for another post due to localstorage. Disabled localstorage in Novel editor to resolve the issue.

2. Title and subtitle were not auto-saving. Fixed the issue by adding a useEffect that auto-saves all the editor content including title and sub-title.
Copy link

vercel bot commented Feb 10, 2024

@vivek7405 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@vivek7405 vivek7405 changed the title Fix issues 380 365: Editor issues and infinite network requests in Post view Fix issues 380 and 365: Editor issues and infinite network requests in Edit Post Feb 10, 2024
@joshualinog
Copy link

@vivek7405 i. could. kiss. you.!!!!!!!!

you are awesome!

this was driving me crazy, especially with early dns issues. i was debugging the wrong things, and your additions to editor.tsx file seems to have fully resolved the post overwrite issue. thank you thank you thank you.

@vivek7405
Copy link
Author

@vivek7405 i. could. kiss. you.!!!!!!!!

you are awesome!

this was driving me crazy, especially with early dns issues. i was debugging the wrong things, and your additions to editor.tsx file seems to have fully resolved the post overwrite issue. thank you thank you thank you.

Thanks for the appreciation! Do me a favor if you can, I'm looking for contract opportunities in the US, let me know if you have any references. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants