Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport v14: Retry manifest file loading only in dev mode (#73900) #74282

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Backport v14: Retry manifest file loading only in dev mode (#73900) #74282

merged 1 commit into from
Dec 24, 2024
+39 −7

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Dec 24, 2024

@unstubbable @ztanner
Retry manifest file loading only in dev mode (#73900)
971bc1b 
In #73891 we added another manifest to be loaded in `loadComponents`
(initially unconditionally). This uncovered a flakiness in prod mode
when attempting to load an optional manifest. The non-existent manifest
is attempted to be loaded three times with 100ms delay between attempts,
before giving up. For some reason the increased loading time leads to
more test flakiness.

To mitigate this, we're limiting the retry behaviour to the dev mode,
which matches the original intention when this was introduced in #45244.
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 24, 2024
@ztanner ztanner marked this pull request as ready for review December 24, 2024 16:51
@ztanner ztanner requested review from feedthejim and ijjk December 24, 2024 16:51
@ijjk
Copy link
Member

ijjk commented Dec 24, 2024 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 24, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
buildDuration 15.5s 13.8s N/A
buildDurationCached 8.6s 6.6s N/A
nodeModulesSize 201 MB 201 MB ⚠️ +7.16 kB
nextStartRea..uration (ms) 406ms 414ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB ✓
5428.HASH.js gzip 181 B 180 B N/A
6067-HASH.js gzip 5.06 kB 5.06 kB N/A
6428-HASH.js gzip 31.6 kB 31.6 kB N/A
framework-HASH.js gzip 44.9 kB 44.9 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.3 kB 32.3 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
_app-HASH.js gzip 196 B 196 B ✓
_error-HASH.js gzip 184 B 185 B N/A
amp-HASH.js gzip 502 B 504 B N/A
css-HASH.js gzip 321 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 258 B 257 B N/A
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 371 B 372 B N/A
image-HASH.js gzip 4.23 kB 4.23 kB N/A
index-HASH.js gzip 259 B 257 B N/A
link-HASH.js gzip 2.67 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 314 B N/A
script-HASH.js gzip 385 B 386 B N/A
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 654 B 654 B ✓
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
_buildManifest.js gzip 483 B 481 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
edge-ssr.js gzip 95.5 kB 95.5 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
middleware-b..fest.js gzip 658 B 657 B N/A
middleware-r..fest.js gzip 156 B 154 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 839 B 839 B ✓
Next Runtimes
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 98.3 kB 98.3 kB ✓
app-page-tur..prod.js gzip 100 kB 100 kB ✓
app-page-tur..prod.js gzip 94.3 kB 94.3 kB ✓
app-page.run...dev.js gzip 146 kB 146 kB ✓
app-page.run..prod.js gzip 92.8 kB 92.8 kB ✓
app-route-ex...dev.js gzip 22.5 kB 22.5 kB ✓
app-route-ex..prod.js gzip 15.9 kB 15.9 kB ✓
app-route-tu..prod.js gzip 15.9 kB 15.9 kB ✓
app-route-tu..prod.js gzip 15.6 kB 15.6 kB ✓
app-route.ru...dev.js gzip 22.1 kB 22.1 kB ✓
app-route.ru..prod.js gzip 15.6 kB 15.6 kB ✓
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB ✓
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB ✓
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.2 kB 23.2 kB ✓
pages.runtim..prod.js gzip 22.5 kB 22.5 kB ✓
server.runti..prod.js gzip 51.6 kB 51.6 kB N/A
Overall change 908 kB 908 kB ✓
build cache
vercel/next.js 14-2-1 vercel/next.js backport/73900 Change
0.pack gzip 1.63 MB 1.63 MB N/A
index.pack gzip 114 kB 114 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 971bc1b

@ztanner ztanner merged commit a7f2879 into 14-2-1 Dec 24, 2024
50 of 55 checks passed
@ztanner ztanner deleted the backport/73900 branch December 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk ijjk approved these changes

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztanner @ijjk @unstubbable