Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React from 7eb8234f-20241218 to ef979d47-20241218 #74104

Conversation

@ijjk ijjk added CI approved Approve running CI for fork type: next labels Dec 18, 2024
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-ef979d47-20241218 branch from 72746ed to abbcfa6 Compare December 18, 2024 22:04
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Failing test suites

Commit: 167d4b6

pnpm test-start test/e2e/app-dir/emotion-js/index.test.ts

  • app dir - emotion-js > should render emotion-js css with compiler.emotion option correctly
Expand output

● app dir - emotion-js › should render emotion-js css with compiler.emotion option correctly

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/app-css/index.test.ts (PPR)

  • app dir - css > Suspensey CSS > should suspend on CSS imports if its slow on client navigation
Expand output

● app dir - css › Suspensey CSS › should suspend on CSS imports if its slow on client navigation

TIMED OUT: /background = rgb\(255, 255, 0\)/

undefined

undefined

  731 |
  732 |   if (hardError) {
> 733 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  734 |   }
  735 |   return false
  736 | }

  at check (lib/next-test-utils.ts:733:11)
  at Object.<anonymous> (e2e/app-dir/app-css/index.test.ts:890:9)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-start test/e2e/app-dir/next-dynamic-css/next-dynamic-css.test.ts (PPR)

  • next-dynamic-css > should have correct order of styles on next/dynamic loaded component
Expand output

● next-dynamic-css › should have correct order of styles on next/dynamic loaded component

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#component')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/actions/app-action.test.ts (PPR)

  • app-dir action handling > should forward action request to a worker that contains the action handler (edge)
  • app-dir action handling > fetch actions > should handle redirects to routes that provide an invalid RSC response
Expand output

● app-dir action handling › should forward action request to a worker that contains the action handler (edge)

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#other-page')

  423 |     return this.chain(() => {
  424 |       return page
> 425 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  426 |         .then(async (el) => {
  427 |           // it seems selenium waits longer and tests rely on this behavior
  428 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:425:10)
  at e2e/app-dir/actions/app-action.test.ts:862:7

● app-dir action handling › fetch actions › should handle redirects to routes that provide an invalid RSC response

expect(received).toContain(expected) // indexOf

Expected substring: "Hello from a pages route"
Received string:    "0.37013413017119934
Client
Server
Client and Server
0
+1+1 (Slow)-1*2
redirect to a pages route
submit
test"

  1269 |
  1270 |       await retry(async () => {
> 1271 |         expect(await browser.elementByCss('body').text()).toContain(
       |                                                           ^
  1272 |           'Hello from a pages route'
  1273 |         )
  1274 |         expect(await browser.url()).toBe(`${next.url}/pages-dir`)

  at toContain (e2e/app-dir/actions/app-action.test.ts:1271:59)
  at retry (lib/next-test-utils.ts:806:14)
  at Object.<anonymous> (e2e/app-dir/actions/app-action.test.ts:1270:7)

Read more about building and testing Next.js in contributing.md.

Copy link

socket-security bot commented Dec 18, 2024

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
buildDuration 30.9s 27.7s N/A
buildDurationCached 28.8s 22.9s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +48.4 kB
nextStartRea..uration (ms) 628ms 949ms ⚠️ +321ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
1187-HASH.js gzip 52.4 kB 52.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
middleware-b..fest.js gzip 668 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 356 kB 358 kB ⚠️ +2.4 kB
app-page-exp..prod.js gzip 129 kB 128 kB N/A
app-page-tur..prod.js gzip 142 kB 141 kB N/A
app-page-tur..prod.js gzip 137 kB 137 kB ⚠️ +466 B
app-page.run...dev.js gzip 347 kB 347 kB ⚠️ +669 B
app-page.run..prod.js gzip 125 kB 125 kB ⚠️ +217 B
app-route-ex...dev.js gzip 37.5 kB 37.4 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.3 kB 25.3 kB N/A
app-route.ru...dev.js gzip 39.1 kB 39.1 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.3 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 1.07 MB 1.07 MB ⚠️ +3.75 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-ef979d47-20241218 Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.8 kB 75.2 kB ⚠️ +419 B
Overall change 74.8 kB 75.2 kB ⚠️ +419 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for bccd1874-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js
failed to diff
Commit: 167d4b6

@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-ef979d47-20241218 branch from abbcfa6 to e9b81ee Compare December 18, 2024 22:32
@eps1lon eps1lon changed the base branch from canary to update/react/19.1.0-canary-7eb8234f-20241218 December 18, 2024 22:32
Copy link
Member

eps1lon commented Dec 18, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eps1lon eps1lon changed the title Upgrade React from 372ec00c-20241209 to ef979d47-20241218 Upgrade React from 7eb8234f-20241218 to ef979d47-20241218 Dec 18, 2024
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-ef979d47-20241218 branch from e9b81ee to ee4db83 Compare December 18, 2024 22:40
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-7eb8234f-20241218 branch from 5092ac7 to b9363cf Compare December 18, 2024 22:50
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-ef979d47-20241218 branch from ee4db83 to d0f8181 Compare December 18, 2024 22:50
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-7eb8234f-20241218 branch from b9363cf to 35ffdbf Compare December 18, 2024 23:07
@eps1lon eps1lon force-pushed the update/react/19.1.0-canary-ef979d47-20241218 branch from d0f8181 to 167d4b6 Compare December 18, 2024 23:07
@eps1lon
Copy link
Member

eps1lon commented Dec 19, 2024

Blocked on facebook/react#31857

@eps1lon eps1lon closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants