Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server/xo-web/VM_coalesceLeaf): implement Coalesce Leaf #7810

Merged
merged 3 commits into from
Jul 15, 2024
Merged

feat(xo-server/xo-web/VM_coalesceLeaf): implement Coalesce Leaf #7810

merged 3 commits into from
Jul 15, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jul 5, 2024 •
edited
Loading

Screenshot

Capture d’écran de 2024-07-11 14-24-42

Description

  • Tested with Damien

Fixes #7757 and zammad#25326

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Jul 5, 2024
@MathieuRA MathieuRA changed the title feat(xapi/VM_leafCoalesce): implement leafCoalesce feat(xo-server/xo-web/VM_leafCoalesce): implement leafCoalesce Jul 8, 2024
MathieuRA
MathieuRA commented Jul 11, 2024
View reviewed changes
@xen-orchestra/xapi/vm.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the leafe-coalesce branch 3 times, most recently from 4ad8411 to 7a8f587 Compare July 11, 2024 12:14
@MathieuRA MathieuRA requested a review from MelissaFrncJrg July 11, 2024 12:34
julien-f
julien-f reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add references to your commit/PR.

@MathieuRA MathieuRA changed the title feat(xo-server/xo-web/VM_leafCoalesce): implement leafCoalesce feat(xo-server/xo-web/VM_coalesceLeaf): implement Coalesce Leaf Jul 11, 2024
@MathieuRA MathieuRA requested a review from julien-f July 15, 2024 08:10
@julien-f julien-f merged commit 4a4122b into master Jul 15, 2024
1 check passed
@julien-f julien-f deleted the leafe-coalesce branch July 15, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelissaFrncJrg MelissaFrncJrg MelissaFrncJrg approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual coalesce for a VM
3 participants
@MathieuRA @julien-f @MelissaFrncJrg