Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Minizip 1.2 #5

Merged
merged 17 commits into from
Aug 27, 2024
Merged

Update to Minizip 1.2 #5

merged 17 commits into from
Aug 27, 2024

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Aug 26, 2024

  • Update vendored Minizip library to v1.2
  • Move files to respect SPM folder structure
  • Add round-tripping test (Round-tripping fails #4)
  • Add DocC catalog
  • Improve code to use new features from Swift 5.8+

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (f4161af) to head (7954635).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   95.90%   96.14%   +0.24%     
==========================================
  Files           6        7       +1     
  Lines         366      337      -29     
==========================================
- Hits          351      324      -27     
+ Misses         15       13       -2     
Files Coverage Δ
Sources/Zip/ArchiveFile.swift 100.00% <100.00%> (ø)
Sources/Zip/Date+dosDate.swift 100.00% <100.00%> (ø)
Sources/Zip/QuickZip.swift 100.00% <100.00%> (ø)
Sources/Zip/Zip.swift 93.36% <100.00%> (ø)
Sources/Zip/ZipCompression.swift 100.00% <ø> (ø)
Sources/Zip/ZipError.swift 100.00% <ø> (ø)
Sources/Zip/ZipUtilities.swift 100.00% <ø> (ø)

@fpseverino fpseverino changed the title Update to Minizip 1.2 Various improvements Aug 26, 2024
@fpseverino fpseverino changed the title Various improvements Update to Minizip 1.2 Aug 26, 2024
@fpseverino fpseverino requested a review from 0xTim August 26, 2024 17:44
@fpseverino fpseverino merged commit f7fc67a into vapor-community:main Aug 27, 2024
10 checks passed
@fpseverino fpseverino deleted the fix-unzip branch August 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants