Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Strict Concurrency #5

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Update for Strict Concurrency #5

merged 5 commits into from
Apr 15, 2024

Conversation

fpseverino
Copy link
Member

  • Add Sendable conformance to PassKit and PassKitDelegate
  • Transition last functions from EventLoopFuture to async/await
  • Update dependencies
  • Improve DooC and README.md

@fpseverino
Copy link
Member Author

In the README I added links to a guide of a Node.js package and to a YouTube video that I found to be very useful when I had to generate the .pem files, but I don't know if it allowed

@fpseverino fpseverino requested a review from gwynne April 3, 2024 16:53
Copy link

codecov bot commented Apr 3, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but nothing related to the Sendable changes, ironically 🙂.

Sources/PassKit/FakeSendable.swift Outdated Show resolved Hide resolved
Sources/PassKit/PassKit.swift Outdated Show resolved Hide resolved
Sources/PassKit/PassKit.swift Outdated Show resolved Hide resolved
@fpseverino fpseverino merged commit d127cae into vapor-community:main Apr 15, 2024
10 of 11 checks passed
@fpseverino fpseverino deleted the update branch April 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants