Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the delegates #15

Merged
merged 17 commits into from
Oct 31, 2024
Merged

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Oct 17, 2024

  • Make PersonalizationJSON a struct instead of a protocol.
    • It was missing only a field that we can make optional, now users directly create the struct and we handle the JSON encoding
  • Move all the signing information from the delegates to the actual services' classes
    • Now users aren't required to use specific URL's initializers, they just pass the path as a String and we create the URL
    • The goal is to completely remove the delegates in the future and move the remaining functions to the PassDataModel and OrderDataModel protocols
  • Make the template delegate method return a String instead of a URL
    • The user provides the path to the directory and we initialize the URL

@fpseverino fpseverino marked this pull request as draft October 18, 2024 20:48
@fpseverino fpseverino marked this pull request as ready for review October 20, 2024 10:08
Copy link
Contributor

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as long as the tests pass.

@fpseverino fpseverino merged commit 53e9146 into vapor-community:main Oct 31, 2024
6 of 11 checks passed
@fpseverino fpseverino deleted the delegate branch October 31, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants