Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path components parsing #116

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fpseverino
Copy link
Member

This PR closes #115

  • Revert path component parsing to a custom URL.pathComponents based one, instead of the one offered by RoutingKit
  • Adopt VaporTesting

This PR fixes a bug that makes almost all services (Google, Auth0, Facebook, etc.) unusable, but it also opens #43 again for said services.

@fpseverino fpseverino added the bug label Dec 27, 2024
@fpseverino fpseverino requested a review from 0xTim December 27, 2024 18:14
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.37%. Comparing base (81e0b74) to head (3f7c4f2).

Files with missing lines Patch % Lines
Sources/ImperialCore/String+pathSegments.swift 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   82.27%   82.37%   +0.09%     
==========================================
  Files          58       59       +1     
  Lines         790      800      +10     
==========================================
+ Hits          650      659       +9     
- Misses        140      141       +1     
Files with missing lines Coverage Δ
Sources/ImperialCore/FederatedServiceRouter.swift 75.00% <100.00%> (ø)
Sources/ImperialGoogle/JWT/GoogleJWTRouter.swift 82.05% <100.00%> (ø)
Sources/ImperialGoogle/Standard/GoogleRouter.swift 97.05% <ø> (ø)
Sources/ImperialCore/String+pathSegments.swift 90.00% <90.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Imperial Beta release: Google completion handler not called
1 participant