connection: add a pointer to os.getpid to ConnectionPool #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a local pointer to
os.getpid
toConnectionPool
class to mitigate theAttributeError
that occurs on Python 3.13+ on interpreter exit. This is caused by the fact that interpreter calls__del__
on variables on exit, butos
is being destroyed before thevalkey.Valkey
instance.It could be easily reproduced with:
Having a local pointer to that function keeps
os.getpid()
accessible during interpreter shutdown.Fixes #158
Pull Request check-list
Description of change