Move parser helpers to irfmt::parsers #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediary step backporting some changes from #20 into main.
This PR focuses on moving the existing parsers into the
irfmt::parsersmodule. Idea is to have parsers (and helpers) under theirfmtmodule for discoverability, similar to theirfmt::printersmodule.In addition to that I implemented the
Parsabletrait forAttrObjandPtr<TypeObj>by copying the formerattr_parseandtype_parsefunction as is into the trait. I did this change to improve symmetry: If a type implementsPrintable, then it should implementParsableas well.Besides implementing
Parsablefor the 2 types there is no change in the implementation logic. Just moving symbols around.