Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run align_mlrun.sh with --with-kfp #1044

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from
Draft

Add option to run align_mlrun.sh with --with-kfp #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f60ce77
Bump MLRun components versin to 1.7.0 and chart version to 0.10.1
adamdelman Nov 28, 2024
bf0164b
Add option to run align_mlrun.sh with --with-kfp
adamdelman Dec 1, 2024
c46caaa
Fix extra_requires
adamdelman Dec 8, 2024
878bbb9
Fix extra_requires
adamdelman Dec 8, 2024
d81a95d
Merge branch 'development' of github.com:v3io/helm-charts into adamd/…
adamdelman Dec 9, 2024
cd66a24
PR Fixes
adamdelman Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/jupyter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: 0.14.40
apiVersion: v1
appVersion: 3.4.8
appVersion: 3.4.9
name: jupyter
description: Jupyter
home: https://jupyter.org/
Expand Down
18 changes: 16 additions & 2 deletions stable/jupyter/templates/jupyter-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,17 @@ data:
log 'Configure align_mlrun.sh script'
cat << EOF > ${ALIGN_MLRUN_SCRIPT}
#!/bin/bash
#IGZ_ALIGN_MLRUN_REV_${ALIGN_MLRUN_REV}
#IGZ_ALIGN_MLRUN_REV_\${ALIGN_MLRUN_REV}
WITH_KFP=0

while [[ "\$#" -gt 0 ]]; do
case \$1 in
--with-kfp) WITH_KFP=1 ;;
*) echo "Unknown parameter passed: \$1"; exit 1 ;;
esac
shift
done

for env in base jupyter; do
if [ "\${CONDA_DEFAULT_ENV-}" = "\${env}" ]; then
echo "Not allowed in conda (\${env}) environment where package updates are not persistent."
Expand All @@ -518,7 +528,11 @@ data:
echo "Updating client..."
pip uninstall -y mlrun
fi
pip install mlrun[complete]==\${SERVER_MLRUN_VERSION}
if [ \${WITH_KFP} -eq 1 ]; then
pip install mlrun[complete,kfp18]==\${SERVER_MLRUN_VERSION}
else
pip install mlrun[complete]==\${SERVER_MLRUN_VERSION}
fi
fi
EOF
chmod a+x ${ALIGN_MLRUN_SCRIPT}
Expand Down
Loading