Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Data management update to support SUA ifaces for Homogen OneDAL tables #2045
ENH: Data management update to support SUA ifaces for Homogen OneDAL tables #2045
Changes from 53 commits
55c9565
402ac3e
67dcba0
1bf8d72
946575a
9ba65c7
39a5531
7fc1d87
7023bb5
8ddfeb5
09bff4a
aa14417
05473c5
1c0933b
70f6ff5
ff21324
9a94cfa
a9c2aa9
bf5c5d1
6b0e3e2
9d3cd89
de12203
e73dc2d
797860f
81b373a
6d327f7
556cae0
09cb477
8b083ba
73df977
8aeff32
385c69f
9ac85ab
9a1ecde
9834d94
14ef77c
19d3f5c
4e4137d
7944187
f240990
ada9369
c85ce27
15cb815
5f8866d
69d09b3
d9c42fb
9723a96
d101f15
e2b8bdb
120df5b
64fd585
a638b92
c92800a
ce2d4ef
c69f967
026aca1
af83fae
4adae13
8eca500
0330fc6
a161eda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment, it helped a lot. I guess is this a problem in oneDAL? I guess if someone was insistent on trying to use the same queue throughout, this would cause them problems as this would generate a new CPU queue. Not a blocker, just something for us to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there no new queue will be created, the queue will be used to copy host data to the usm allocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will open the possibility that we will store non-numpy arrays as stored estimator attributes (we can store USM, not array api compliant values). This is going to complicate things when a computation falls back to sklearn in a fit step, the results could be of a completely different type. How will this be handled with fit attributes which fallback, do we iterate on and convert all instance attributes? At minimum please make a ticket into an investigation into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shouldn't be a follow up ticket of this PR. I don't think that without any input it is needed to create any ticket.
Potentially this could be raised on DBSCAN via Array API enabling with this PR changes integration, since stock scikit-learn doesn't support non-numpy array inputs.
This file was deleted.