Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user from stuck state if auth token refresh fails #189

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

achandrabalan
Copy link

@achandrabalan achandrabalan commented Apr 21, 2024

Notion ticket link

Refresh Token Error

Implementation description

  • When a refresh fails, forcibly remove the user's invalid auth token from the local storage. Triggering a new token to be created.

Steps to test

Testing that a missing refresh token is handled:

Log in to your local environment.
Set your system time to a time at least a week in the future.
Close your browser fully and reopen it.
Load any page that pulls data from the backend, and verify that you are logged out.

hehe thanks Connor ^

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@achandrabalan
Copy link
Author

Please run linter for me (pretty plz) :)

@owen-sellner owen-sellner self-requested a review May 3, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant