Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node versions #183

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

update node versions #183

wants to merge 5 commits into from

Conversation

maishathasin
Copy link
Member

Notion ticket link

Ticket Name

Implementation description

  • Updating node versions from 14.5.5 to 16.0.0

Steps to test

  1. Build docker image for frontend and backend

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Nov 27, 2023

Visit the preview URL for this PR (updated for commit a21fb73):

https://uw-blueprint-starter-code--pr183-node-version-fpa2yx7u.web.app

(expires Wed, 06 Dec 2023 04:12:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8a9d9b9ea27110b294ec3954ff89dab270e34c45

Copy link
Contributor

@billcui57 billcui57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have a question

.github/workflows/firebase-hosting-pull-request.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@billcui57 billcui57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants