Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $200 donation option #355

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Add $200 donation option #355

merged 4 commits into from
Jun 21, 2024

Conversation

sherryhli
Copy link
Member

@sherryhli sherryhli commented Mar 4, 2024

Notion ticket link

Shopify donation issues

Implementation description

  • Created new $200 donation product in Shopify
  • Modified renewal form and validations to handle new $200 option

Notes

  • Need to set new product id env variable in prod when deploying

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@ChinemeremChigbo
Copy link
Member

Looks good, I share your concerns about our ability to test and am curious if it's worth trying to reactivate our Shopify dev store. Also, it might be helpful if you also add "200" to line 22 of .env.sample

image

@sherryhli sherryhli force-pushed the sl/add-200-donation-option branch from 385c1b4 to 38042fc Compare June 20, 2024 04:36
@sherryhli
Copy link
Member Author

Tested by using prod shopify store (did not complete checkout)
Capture

$200 donation product seen on checkout page:
Capture1

@sherryhli sherryhli marked this pull request as ready for review June 20, 2024 04:42
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sherryhli sherryhli merged commit 141e654 into staging Jun 21, 2024
1 check passed
@sherryhli sherryhli deleted the sl/add-200-donation-option branch June 21, 2024 02:00
leogjhuang pushed a commit that referenced this pull request Jun 21, 2024
* Add $200 donation option

* Add $200 donation option

* Update .env.sample with $200 donation product id

---------

Co-authored-by: Chinemerem <[email protected]>
leogjhuang added a commit that referenced this pull request Jun 21, 2024
* Add Sharujan to employees.ts (#360)

* [Improvement] Add Mail Lost Option as Replacement Reason (#340)

* initial commit for the mail lost option

* changed the processing fee for mail lost

* made the migrations for mail lost

* reverted yarn lock to staging

* initial commit for the mail lost option

* changed the processing fee for mail lost

* made the migrations for mail lost

* reverted yarn lock to staging

---------

Co-authored-by: Chinemerem <[email protected]>

* Add $200 donation option (#355)

* Add $200 donation option

* Add $200 donation option

* Update .env.sample with $200 donation product id

---------

Co-authored-by: Chinemerem <[email protected]>

* Change address from unit 842 to 968 (#361)

* [Fix] Add AMEX as a second payment option (#362)

* [Feature] Add receipt numbers to application reports (#363)

* [Misc] Update README.md (#364)

---------

Co-authored-by: Chinemerem <[email protected]>
Co-authored-by: Keane Moraes <[email protected]>
Co-authored-by: Sherry Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants