Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCP Dashboard Audit #83

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

CCP Dashboard Audit #83

wants to merge 10 commits into from

Conversation

patrick-du
Copy link
Contributor

@patrick-du patrick-du commented Jan 16, 2021

Notion ticket
Associated Backend PR

Changes

  • Refer to Notion ticket

Screenshots

iPad Pro
image

iPad
image

Aligned triage field
image

Patient dialog
image

Testing

  • Ensure CCP dashboard elements are properly sized in iPad/iPad Pro (landscape orientation)
  • Ensure patients table includes CTAs field and Last Edited field puts appropriate time (as explained in Notion ticket)
  • Ensure the triage field in the patient's table for a deleted patient is aligned with un-deleted patients
  • Ensure patient dialog:
    • Includes CTAS, Ambulance, Last Edited fields
    • All triage colors are now in black
    • Aligned labels and values (as shown in Notion ticket)
  • Ensure patient CTA can be edited after clicking "Edit" in the patient dialog

Checklist

Code review doc for reference

before opening PR

  • check notion ticket
  • run linter
  • go through file diff

filling out PR

  • descriptive title
  • update notion ticket link
  • update figma link
  • fill out Changes
    • (optional) add inline comments in diff
  • fill out Testing
  • (optional) add Screenshots
  • assign yourself to the PR

after opening PR

  • link PR to notion ticket
  • move ticket to In PR
  • make sure build passes
  • ping @ps in #paramedics-dev

Copy link
Collaborator

@petorsong petorsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of issues i've found:

  • hospital overview tab is not properly formatted on ipad sizing
    image
  • also getting some errors over the patient details dialog
    image
    image
    image

@patrick-du patrick-du requested a review from petorsong January 27, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants