Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable backdrop in dialogs and modals #68

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Disable backdrop in dialogs and modals #68

wants to merge 2 commits into from

Conversation

patrick-du
Copy link
Contributor

Notion ticket

Figma link

Changes

  • Added the property disableBackdropClick to prevent users from closing the modal/dialog by clicking outside of it
    • Fixes problem 1 described in the Notion ticket
    • Also fixes the ccp dashboard interacts weirdly with the menu popper problem

Screenshots

Testing

Checklist

Code review doc for reference

before opening PR

  • check notion ticket
  • run linter
  • go through file diff

filling out PR

  • descriptive title
  • update notion ticket link
  • update figma link
  • fill out Changes
    • (optional) add inline comments in diff
  • fill out Testing
  • (optional) add Screenshots
  • assign yourself to the PR

after opening PR

  • link PR to notion ticket
  • move ticket to In PR
  • make sure build passes
  • ping @ps in #paramedics-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patrick-du